Re: [BUG] pg_upgrade test fails from older versions. - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: [BUG] pg_upgrade test fails from older versions.
Date
Msg-id 20221223163925.GR1153@telsasoft.com
Whole thread Raw
In response to Re: [BUG] pg_upgrade test fails from older versions.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [BUG] pg_upgrade test fails from older versions.  (Michael Paquier <michael@paquier.xyz>)
Re: [BUG] pg_upgrade test fails from older versions.  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Fri, Dec 23, 2022 at 05:51:28PM +0900, Michael Paquier wrote:
> On Thu, Dec 22, 2022 at 09:27:24PM -0600, Justin Pryzby wrote:
> > This would do a single seqscan:
> > SELECT format('ALTER TABLE %I ALTER COLUMN %I TYPE TEXT',
> > attrelid::regclass, attname) FROM pg_attribute WHERE
> > atttypid='aclitem'::regtype; -- AND ...
> > \gexec
> 
> FWIW, I find the use of a FOR loop with a DO block much cleaner to
> follow in this context, so something like the attached would be able
> to group the two queries and address your point on O(N^2).  Do you
> like that? 

LGTM.  Thanks.

-- 
Justin



pgsql-hackers by date:

Previous
From: "Takamichi Osumi (Fujitsu)"
Date:
Subject: RE: Time delayed LR (WAS Re: logical replication restrictions)
Next
From: Justin Pryzby
Date:
Subject: Re: [RFC] building postgres with meson - v13