Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h
Date
Msg-id 20221203181722.ib6fwzuorhktpmhz@awork3.anarazel.de
Whole thread Raw
In response to Replace PROC_QUEUE / SHM_QUEUE with ilist.h  (Andres Freund <andres@anarazel.de>)
Responses Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2022-11-19 21:59:30 -0800, Andres Freund wrote:
> In [1] Robert justifiably complained about the use of PROC_QUEUE. I've
> previously been bothered by this in [2], but didn't get around to finishing
> the patches.
> 
> One thing that made me hesitate was the naming of the function for a) checking
> whether a dlist_node is a list, b) initializing and deleting nodes in a way to
> allow for a).  My patch adds dlist_node_init(), dlist_delete_thoroughly() /
> dlist_delete_from_thoroughly() / dclist_delete_from_thoroughly() and
> dlist_node_is_detached().  Thomas proposed dlist_delete_and_reinit() and
> dlist_node_is_linked() instead.

Any comments on these names? Otherwise I'm planning to push ahead with the
names as is, lest I forget this patchset for another ~2 years.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: Transaction timeout
Next
From: David Rowley
Date:
Subject: Re: Questions regarding distinct operation implementation