Re: Add tracking of backend memory allocated to pg_stat_activity - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Add tracking of backend memory allocated to pg_stat_activity
Date
Msg-id 20221127154053.GS11463@telsasoft.com
Whole thread Raw
In response to Re: Add tracking of backend memory allocated to pg_stat_activity  (Reid Thompson <reid.thompson@crunchydata.com>)
Responses Re: Add tracking of backend memory allocated to pg_stat_activity
Re: Add tracking of backend memory allocated to pg_stat_activity
List pgsql-hackers
On Sun, Nov 27, 2022 at 12:32:19AM -0500, Reid Thompson wrote:
> @@ -32,6 +33,12 @@ typedef enum BackendState
>      STATE_DISABLED
>  } BackendState;
>  
> +/* Enum helper for reporting memory allocated bytes */
> +enum allocation_direction
> +{
> +    DECREASE = -1,
> +    INCREASE = 1,
> +};

BTW, these should have some kind of prefix, like PG_ALLOC_* to avoid
causing the same kind of problem for someone else that another header
caused for you by defining something somewhere called IGNORE (ignore
what, I don't know).  The other problem was probably due to a define,
though.  Maybe instead of an enum, the function should take a boolean.

I still wonder whether there needs to be a separate CF entry for the
0001 patch.  One issue is that there's two different lists of people
involved in the threads.

-- 
Justin



pgsql-hackers by date:

Previous
From: Ted Yu
Date:
Subject: Re: Add tracking of backend memory allocated to pg_stat_activity
Next
From: Tomas Vondra
Date:
Subject: Re: pglz compression performance, take two