Re: pgstattuple: add test for coverage - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pgstattuple: add test for coverage
Date
Msg-id 20221122222812.kxn2rlhk7norl7za@awork3.anarazel.de
Whole thread Raw
In response to Re: pgstattuple: add test for coverage  (Dong Wook Lee <sh95119@gmail.com>)
List pgsql-hackers
Hi,

On 2022-10-03 00:42:27 +0900, Dong Wook Lee wrote:
> > Which indeed is the case, e.g. on 32bit systems it fails:
> >
> > https://cirrus-ci.com/task/4619535222308864?logs=test_world_32#L253
> >
> >
https://api.cirrus-ci.com/v1/artifact/task/4619535222308864/testrun/build-32/testrun/pgstattuple/regress/regression.diffs
> >
> >   table_len | tuple_count | tuple_len | tuple_percent | dead_tuple_count | dead_tuple_len | dead_tuple_percent |
free_space| free_percent
 
> >
-----------+-------------+-----------+---------------+------------------+----------------+--------------------+------------+--------------
> > -   1171456 |        5000 |    560000 |          47.8 |             5000 |         560000 |               47.8 |
  7452 |         0.64
 
> > +   1138688 |        5000 |    540000 |         47.42 |             5000 |         540000 |              47.42 |
 14796 |          1.3
 
> >  (1 row)
> >
> > ...
> >
> >
> > You definitely can't rely on such details not to change across platforms.

> Thank you for letting me know I'll fix it and check if there's any problem.

I've marked the patch as returned with feedback for now. Please change that
once you submit an updated version.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: TAP output format in pg_regress
Next
From: Andrew Dunstan
Date:
Subject: Re: More efficient build farm animal wakeup?