Re: Catalog_xmin is not advanced when a logical slot is lost - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Catalog_xmin is not advanced when a logical slot is lost
Date
Msg-id 20221122100108.5oh2fysbrwg3r6hi@alvherre.pgsql
Whole thread Raw
In response to Re: Catalog_xmin is not advanced when a logical slot is lost  (sirisha chamarthi <sirichamarthi22@gmail.com>)
List pgsql-hackers
On 2022-Nov-21, sirisha chamarthi wrote:

> On Mon, Nov 21, 2022 at 10:56 AM Alvaro Herrera <alvherre@alvh.no-ip.org>
> wrote:

> > Instead I'm going to do what Ashutosh mentioned at the start, which is
> > to verify both the restart_lsn and the invalidated_at, when deciding
> > whether to ignore the slot.
> 
> Sounds good to me. Thanks!

Done now.  I also a new elog(DEBUG1), which I think makes the issue a
bit easier notice.

I think it would be even better if we reset the underlying data from
effective_catalog_xmin ... even with this patch, we show a non-zero
value for a slot in status "lost" (and we ignore it when computing the
overall xmin), which I think is quite confusing.  But we can do that in
master only.

Thanks for reporting this issue.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: gkokolatos@pm.me
Date:
Subject: Re: Add LZ4 compression in pg_dump
Next
From: igor levshin
Date:
Subject: Re: allowing for control over SET ROLE