Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures - Mailing list pgsql-hackers

Hmm, in 0002, why not return the timeline from the LSN too?  It seems a
waste not to have it.

+        ereport(ERROR,
+                (errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
+                 errmsg("\"offset\" must not be negative or greater than or "
+                        "equal to WAL segment size")));

I don't think the word offset should be in quotes; and please don't cut
the line.  So I propose

   errmsg("offset must not be negative or greater than or equal to the WAL segment size")));

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/