Re: Fix proposal for comparaison bugs in PostgreSQL::Version - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Fix proposal for comparaison bugs in PostgreSQL::Version
Date
Msg-id 20221103181118.GX16921@telsasoft.com
Whole thread Raw
In response to Re: Fix proposal for comparaison bugs in PostgreSQL::Version  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Fix proposal for comparaison bugs in PostgreSQL::Version
List pgsql-hackers
On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote:
> Nice catch, but this looks like massive overkill. I think we can very
> simply fix the test in just a few lines of code, instead of a 190 line
> fix and a 130 line TAP test.
> 
> It was never intended to be able to compare markers like rc1 vs rc2, and
> I don't see any need for it. If you can show me a sane use case I'll
> have another look, but right now it seems quite unnecessary.
> 
> Here's my proposed fix.
> 
> diff --git a/src/test/perl/PostgreSQL/Version.pm b/src/test/perl/PostgreSQL/Version.pm
> index 8f70491189..8d4dbbf694 100644
> --- a/src/test/perl/PostgreSQL/Version.pm

Is this still an outstanding issue ?

-- 
Justin



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: security_context_t marked as deprecated in libselinux 3.1
Next
From: Andrew Dunstan
Date:
Subject: Re: ssl tests aren't concurrency safe due to get_free_port()