Re: make_ctags: use -I option to ignore pg_node_attr macro - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: make_ctags: use -I option to ignore pg_node_attr macro
Date
Msg-id 20221019.132517.1083262091188312375.t-ishii@sranhm.sra.co.jp
Whole thread Raw
In response to Re: make_ctags: use -I option to ignore pg_node_attr macro  (Yugo NAGATA <nagata@sraoss.co.jp>)
Responses Re: make_ctags: use -I option to ignore pg_node_attr macro  (Yugo NAGATA <nagata@sraoss.co.jp>)
Re: make_ctags: use -I option to ignore pg_node_attr macro  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
> Hi,
> 
> On Sat, 15 Oct 2022 10:40:29 +0900 (JST)
> Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
> 
>> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST)
>> > Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> > 
>> >> > OK, that sounds good then.  I would make a feature request to have a
>> >> > switch that supresses creation of these links, then.
>> >> 
>> >> Ok, I have added "-n" option to make_ctags so that it skips to create
>> >> the links.
>> >> 
>> >> Also I have changed make_etags so that it exec make_ctags, which seems
>> >> to be the consensus.
>> > 
>> > Thank you for following up my patch.
>> > I fixed the patch to allow use both -e and -n options together.
>> 
>> Thanks. I have made mostly cosmetic changes so that it is more
>> consistent with existing scripts.
>> 
>> I would like to push v6 patch if there's no objection.
> 
> I am fine with this patch.

Thanks. the v6 patch pushed to master branch.

> By the way, in passing, how about adding "tags" and "TAGS" to
> .gitignore file?

Sounds like a good idea.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639)
Next
From: Yugo NAGATA
Date:
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro