Re: START_REPLICATION SLOT causing a crash in an assert build - Mailing list pgsql-hackers

From Andres Freund
Subject Re: START_REPLICATION SLOT causing a crash in an assert build
Date
Msg-id 20221008174000.mpp2vxldtlj6yj34@awork3.anarazel.de
Whole thread Raw
In response to Re: START_REPLICATION SLOT causing a crash in an assert build  (Andres Freund <andres@anarazel.de>)
Responses Re: START_REPLICATION SLOT causing a crash in an assert build  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
On 2022-10-08 09:53:50 -0700, Andres Freund wrote:
> On 2022-10-07 19:56:33 -0700, Andres Freund wrote:
> > I'm planning to push this either later tonight (if I feel up to it after
> > cooking dinner) or tomorrow morning PST, due to the release wrap deadline.
>
> I looked this over again, tested a bit more, and pushed the adjusted 15 and
> master versions to github to get a CI run. Once that passes, as I expect, I'll
> push them for real.

Those passed and thus pushed.

Thanks for the report, debugging and review everyone!


I think we need at least the following tests for replslots:
- a reset while decoding is ongoing works correctly
- replslot stats continue to be accumulated after stats have been removed


I wonder how much it'd take to teach isolationtester to handle the replication
protocol...



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Adding Support for Copy callback functionality on COPY TO api
Next
From: Tom Lane
Date:
Subject: Re: Non-robustness in pmsignal.c