Postgres Pro
Downloads
Home   >   mailing lists

Re: How to retain lesser paths at add_path()? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: How to retain lesser paths at add_path()?
Date
Msg-id 20221002165924.3vvtdj67ya3x3gox@awork3.anarazel.de
Whole thread Raw
In response to Re: How to retain lesser paths at add_path()?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
Hi,

On 2022-07-31 16:05:20 -0400, Tom Lane wrote:
> Thoughts?

As the patch got some feedback ~2 months ago, I'm updating the status to
waiting-for-author.

Minor note: cfbot complains about a cpluspluscheck violation:

[12:24:50.124] time make -s cpluspluscheck EXTRAFLAGS='-fmax-errors=10'
[12:25:17.757] In file included from /tmp/cpluspluscheck.AoEDdi/test.cpp:3:
[12:25:17.757] /tmp/cirrus-ci-build/src/include/optimizer/pathnode.h: In function ‘PathComparison
path_comparison_combine(PathComparison,PathComparison)’:
 
[12:25:17.757] /tmp/cirrus-ci-build/src/include/optimizer/pathnode.h:39:19: error: invalid conversion from ‘int’ to
‘PathComparison’[-fpermissive]
 
[12:25:17.757]    39 |  return (c1 | c2) & PATH_COMPARISON_MASK;
[12:25:17.757]       |                   ^
[12:25:17.757]       |                   |
[12:25:17.757]       |                   int
[12:25:33.857] make: *** [GNUmakefile:141: cpluspluscheck] Error 1

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Proposal for internal Numeric to Uint64 conversion function.
Next
From: Andres Freund
Date:
Subject: Re: Improve TAP tests of pg_upgrade for cross-version tests