Re: TAP output format in pg_regress - Mailing list pgsql-hackers

From Andres Freund
Subject Re: TAP output format in pg_regress
Date
Msg-id 20221002010153.k5rvcmlqczksdujq@awork3.anarazel.de
Whole thread Raw
In response to Re: TAP output format in pg_regress  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: TAP output format in pg_regress  (Nikolay Shaplov <dhyan@nataraj.su>)
List pgsql-hackers
Hi,

On 2022-09-01 14:21:18 +0200, Daniel Gustafsson wrote:
> Attached is a v8 which fixes a compiler warning detected by the CFBot.

cfbot at the moment does show a warning. A bit surprised to see this warning
enabled by default in gcc, but it seems correct here:

[20:57:02.892] make -s -j${BUILD_JOBS} clean
[20:57:03.326] time make -s -j${BUILD_JOBS} world-bin
[20:57:12.882] pg_regress.c: In function ‘bail’:
[20:57:12.882] pg_regress.c:219:2: error: function ‘bail’ might be a candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute=format]
[20:57:12.882]   219 |  vsnprintf(tmp, sizeof(tmp), fmt, ap);
[20:57:12.882]       |  ^~~~~~~~~

Now that meson is merged, it'd be worthwhile to change the invocation for
pg_regress in the toplevel meson.build (search for "Test Generation").


Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: CI and test improvements
Next
From: Andres Freund
Date:
Subject: Re: Tightening behaviour for non-immutable behaviour in immutable functions