Re: Make ON_ERROR_STOP stop on shell script failure - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Make ON_ERROR_STOP stop on shell script failure
Date
Msg-id 20220929.135109.686813839550314879.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Make ON_ERROR_STOP stop on shell script failure  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
At Thu, 29 Sep 2022 12:35:04 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> > Thank you for the feedback!
> > I agree that the messages should be more clear.
> > \\!: command was not executed
> > \\!: command failed
> > Would these two messages be enough to describe the two cases?
> 
> FWIW, I would spell these as something like this:
> 
> > \\!: command execution failure: %m

The following might be more complient to our policy.

> \\!: failed to execute command \"%s\": %m


> > \\!: command returned failure status: %d

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Eliminating SPI from RI triggers - take 2
Next
From: Masahiko Sawada
Date:
Subject: Re: [PATCH] Log details for client certificate failures