Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits. - Mailing list pgsql-committers

From Justin Pryzby
Subject Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.
Date
Msg-id 20220927185121.GE6256@telsasoft.com
Whole thread Raw
In response to pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.  (Robert Haas <rhaas@postgresql.org>)
List pgsql-committers
This seems to be breaking cfbot:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql

For example:
https://cirrus-ci.com/task/6720256776339456

Some other minor issues:

thais is only used during

=> this

+                       elog(ERROR, "unexpected relnumber " UINT64_FORMAT "that is bigger than nextRelFileNumber "
UINT64_FORMAT,

=> there should be a space before "that".

+                                                "tli %u; prev tli %u; fpw %s; xid %u:%u; relfilenumber " UINT64_FORMAT
";oid%u; "
 

=> and a space before "oid"

+ * Parse relfilenumber value for an option.  If the parsing is successful,
+ * returns; if parsing fails, returns false.

returns *true;



pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Include common/relpath.h in utils/relfilenumbermap.h
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Convert *GetDatum() and DatumGet*() macros to inline functions