Re: [RFC] building postgres with meson - v13 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [RFC] building postgres with meson - v13
Date
Msg-id 20220926064654.klmyhdas33bzil3y@awork3.anarazel.de
Whole thread Raw
In response to RE: [RFC] building postgres with meson - v13  ("wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>)
Responses RE: [RFC] building postgres with meson - v13
List pgsql-hackers
Hi,

On 2022-09-26 06:24:42 +0000, wangw.fnst@fujitsu.com wrote:
> I tried to use meson and ninja and they are really efficient.
> But when I tried to specify "c_args", it did not take effect.

They should take effect, but won't be shown in the summary section
currently. That currently only shows the flags chosen by the configure step,
rather than user specified ones.


> After I made the below modifications, the specified "c_args" took effect.
> ```
> @@ -2439,6 +2439,10 @@ endif
> 
>  # Set up compiler / linker arguments to be used everywhere, individual targets
>  # can add further args directly, or indirectly via dependencies
> +
> +tmp_c_args = get_option('c_args')
> +cflags += tmp_c_args
> +
>  add_project_arguments(cflags, language: ['c'])
>  add_project_arguments(cppflags, language: ['c'])
>  add_project_arguments(cflags_warn, language: ['c'])
> ```

That'll likely end up with the same cflags added multiple times. You should
see them when building with ninja -v.

How about adding c_args to the summary, in a separate line? I think that'd
clarify what's happening?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Wolfgang Walther
Date:
Subject: Re: Add ON CONFLICT DO RETURN clause
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"