Re: tweak to a few index tests to hits ambuildempty() routine. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: tweak to a few index tests to hits ambuildempty() routine.
Date
Msg-id 20220925155707.2uc35oe3h4ckd4j5@alvherre.pgsql
Whole thread Raw
In response to Re: tweak to a few index tests to hits ambuildempty() routine.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: tweak to a few index tests to hits ambuildempty() routine.
List pgsql-hackers
On 2022-Sep-25, Tom Lane wrote:

> That's what it's saying *now*, but after rereading this whole thread
> I see that it apparently said something different last week.  So the
> coverage is probabilistic, which squares with this discussion and
> with some tests I just did locally.  That's not good.

Completely agreed.

> I propose that we revert 4fb5c794e and instead add separate test
> cases that just create unlogged indexes (I guess they don't actually
> need to *do* anything with them?).

WFM.  I can do it next week, or feel free to do so if you want.

> Looks like dec8ad367 could be reverted as well, in view of 2f2e24d90.

Yeah, sounds good.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Wolfgang Walther
Date:
Subject: Add ON CONFLICT DO RETURN clause
Next
From: Tom Lane
Date:
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.