Re: test_decoding assertion failure for the loss of top-sub transaction relationship - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: test_decoding assertion failure for the loss of top-sub transaction relationship
Date
Msg-id 20220902.131605.1265582568212097194.horikyota.ntt@gmail.com
Whole thread Raw
In response to RE: test_decoding assertion failure for the loss of top-sub transaction relationship  ("kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
Good catch, and thanks for the patch!

At Fri, 2 Sep 2022 01:08:04 +0000, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com> wrote in 
> PSA patch that fixes the failure.
> This adds pairs of sub-top transactions to the SnapBuild, and it will be serialized and restored.
> The pair will be checked when we mark the ReorderBufferTXN as RBTXN_HAS_CATALOG_CHANGES.

A commit record has all subtransaction ids and SnapBuildCommitTxn()
already checks if every one has catalog changes before checking the
top transaction's catalog changes. So, no need to record top-sub
transaction relationship to serialized snapshots. If any of the
subtransactions has catalog changes, the commit contains catalog
changes.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Column Filtering in Logical Replication
Next
From: Andrey Lepikhov
Date:
Subject: Re: [HACKERS] PoC: custom signal handler for extensions