Re: pgsql: Remove unnecessary casts in free() and pfree() - Mailing list pgsql-committers

From Justin Pryzby
Subject Re: pgsql: Remove unnecessary casts in free() and pfree()
Date
Msg-id 20220827112304.GL2342@telsasoft.com
Whole thread Raw
In response to pgsql: Remove unnecessary casts in free() and pfree()  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: Remove unnecessary casts in free() and pfree()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Fri, Aug 26, 2022 at 02:02:33PM +0000, Peter Eisentraut wrote:
> Remove unnecessary casts in free() and pfree()

This seems to be breaking cfbot's "warnings" test.

[07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards ‘const’ qualifier from pointer target type
[-Werror=discarded-qualifiers]
[07:49:48.983]   665 |    pfree(temp);

I imagine it would've been reported earlier, except that this commit was within
60min of the commit that broke perl.

-- 
Justin



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Be more careful to avoid including system headers after perl.h
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Fix typo in comment for writetuple() function