Re: [PATCH] Add native windows on arm64 support - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Add native windows on arm64 support
Date
Msg-id 20220826032943.nwoepbegzwntbmks@awork3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] Add native windows on arm64 support  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Add native windows on arm64 support
List pgsql-hackers
Hi,

On 2022-08-26 11:09:41 +0900, Michael Paquier wrote:
> On Thu, Aug 25, 2022 at 06:29:07PM -0700, Andres Freund wrote:
> > I accidentally did a lot of testing with DYNAMICBASE - I accidentally
> > mistranslated MSBuildProject.pm's <RandomizedBaseAddress>false</> to adding
> > /DYNAMICBASE in the meson port. Survived several hundred CI cycles and dozens
> > of local runs without observing any problems related to that.
> > 
> > Which doesn't surprise me, given the way we reserve space in the new process.
> 
> Still, we had problems with that in the past and I don't recall huge
> changes in the way we allocate shmem on WIN32.

It's really not great that 7f3e17b4827 disabled randomization without even a
comment as to why...

There actually seems to have been a lot of work in that area. See 617dc6d299c
/ bcbf2346d69 and as well as the retrying in 45e004fb4e39. Those weren't
prevented by us disabling ASLR.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: use SSE2 for is_valid_ascii
Next
From: John Naylor
Date:
Subject: Re: use ARM intrinsics in pg_lfind32() where available