Re: add checkpoint stats of snapshot and mapping files of pg_logical dir - Mailing list pgsql-hackers

On Wed, Aug 17, 2022 at 11:17:24AM +0530, Bharath Rupireddy wrote:
> +                        "logical decoding file(s) processing time=%ld.%03d s",

I would suggest shortening this to something like "logical decoding
processing" or "logical replication processing."

>      CheckPointRelationMap();
>      CheckPointReplicationSlots();
> +
> +    CheckpointStats.l_dec_ops_start_t = GetCurrentTimestamp();
>      CheckPointSnapBuild();
>      CheckPointLogicalRewriteHeap();
> +    CheckpointStats.l_dec_ops_end_t = GetCurrentTimestamp();
> +
>      CheckPointReplicationOrigin();

Shouldn't we include CheckPointReplicationSlots() and
CheckPointReplicationOrigin() in this new stat?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com