On Fri, Aug 19, 2022 at 03:11:36PM +0700, John Naylor wrote:
> This is done. Also:
> - a complete overhaul of the pg_lfind8* tests
> - using a typedef for the vector type
> - some refactoring, name changes and other cleanups (a few of these
> could also be applied to the 32-byte element path, but that is left
> for future work)
>
> TODO: json-specific tests of the new path
This looks pretty good to me. Should we rename vector_broadcast() and
vector_has_zero() to indicate that they are working with bytes (e.g.,
vector_broadcast_byte())? We might be able to use vector_broadcast_int()
in the 32-bit functions, and your other vector functions already have a
_byte suffix.
In general, the approach you've taken seems like a decent readability
improvement. I'd be happy to try my hand at adjusting the 32-bit path and
adding ARM versions of all this stuff.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
