Re: tests and meson - test names and file locations - Mailing list pgsql-hackers

From Andres Freund
Subject Re: tests and meson - test names and file locations
Date
Msg-id 20220811150634.i236t6jkk4zuyocl@awork3.anarazel.de
Whole thread Raw
In response to Re: tests and meson - test names and file locations  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: tests and meson - test names and file locations
Re: tests and meson - test names and file locations
List pgsql-hackers
Hi,

On 2022-08-11 10:20:42 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > I also like that. I think we should take this opportunity for some
> > serious rationalization of this. Tests and associated data have grown
> > rather like Topsy, and we should fix that. So please don't feel too
> > constrained by current practice.
> 
> I'm definitely -1 on that.  Major rearrangement of the test scripts
> would be a huge blocking factor for almost any back-patch.  I don't
> care much if you want to rearrange how the tests are invoked, but
> please don't touch the individual .sql and .pl scripts.

I don't precisely know what Andrew was thinking of, but the relocation of log
files for example doesn't require many changes to .pl files - one change to
Utils.pm. The one exception to that is 010_tab_completion.pl, which encodes
tmp_check/ in its output.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaning up historical portability baggage
Next
From: Andres Freund
Date:
Subject: Re: pg_upgrade test writes to source directory