Re: pgsql: Rely on __func__ being supported - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Rely on __func__ being supported
Date
Msg-id 20220807174014.xuz7i47oi3ovgwgd@alvherre.pgsql
Whole thread Raw
In response to pgsql: Rely on __func__ being supported  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Rely on __func__ being supported  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
On 2022-Aug-07, Andres Freund wrote:

> Rely on __func__ being supported
> 
> Previously we fell back to __FUNCTION__ and then NULL. As __func__ is in C99
> that shouldn't be necessary anymore.
> 
> Solution.pm defined HAVE_FUNCNAME__FUNCTION instead of
> HAVE_FUNCNAME__FUNC (originating in 4164e6636e2), as at some point in the past
> MSVC only supported __FUNCTION__. Our minimum version supports __func__.

I'd rather we keep PG_FUNCNAME_MACRO defined to __func__ ... it costs us
nothing.  Would anybody oppose that?

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Attachment

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Trust a few system headers to stand on their own
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Rely on __func__ being supported