Hi,
On 2022-08-07 14:29:20 +1200, Thomas Munro wrote:
> On Sun, Aug 7, 2022 at 1:29 PM Andres Freund <andres@anarazel.de> wrote:
> > 0001: __func__ is C99, so we don't need to support fallbacks
>
> +1, and my scraped data agrees.
>
> I believe our minimum MSVC is current 2015, and this says it has it
> (it doesn't let you select older versions in the version drop-down,
> but we don't care about older versions):
Thanks for checking.
> > 0002: windows: We've unconditionally defined HAVE_MINIDUMP_TYPE for msvc forever, we
> > can rely on it for mingw too
>
> * If supported on the current platform, set up a handler to be called if
> * the backend/postmaster crashes with a fatal signal or exception.
> */
> -#if defined(WIN32) && defined(HAVE_MINIDUMP_TYPE)
> +#if defined(WIN32)
>
> Personally I'd remove "If supported on the current platform, " and
> shove the rest of the comment inside the #if defined(WIN32), but
> that's just me...
I started out that way as well, but it'd actually be nice to do this on other
platforms too, and we just don't support it yet :)
> > I checked and the relevant options (-shared, -Wl,-Bsymbolic, -Wl,-soname)
> > work even on solaris 10 with developerstudio12.5 (not the latest)
>
> FWIW I'd call Solaris 10 EOL'd (it's in some
> sure-pay-us-but-we-aren't-really-going-to-fix-it phase with a lifetime
> similar to the actual sun).
I'd agree - but checked so that couldn't even be an argument against :)
Greetings,
Andres Freund
