Re: Custom tuplesorts for extensions - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Custom tuplesorts for extensions
Date
Msg-id 20220724232305.GH7789@telsasoft.com
Whole thread Raw
In response to Re: Custom tuplesorts for extensions  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: Custom tuplesorts for extensions
List pgsql-hackers
Note that 0001+0002 (without the others) incurs warnings:

$ time { make -j4 clean; make -j4; } >/dev/null
tuplesort.c:1883:9: warning: unused variable 'i' [-Wunused-variable]
tuplesort.c:1955:10: warning: unused variable 'i' [-Wunused-variable]
tuplesort.c:2026:9: warning: unused variable 'i' [-Wunused-variable]
tuplesort.c:2103:10: warning: unused variable 'i' [-Wunused-variable]

(I wondered in the past if cfbot should try to test for clean builds of subsets
of patchsets, and it came up recently with the JSON patches.)

Also, this comment has some bad indentation:

* Set state to be consistent with never trying abbreviation.

-- 
Justin



pgsql-hackers by date:

Previous
From: Kenaniah Cerny
Date:
Subject: Re: Proposal: allow database-specific role memberships
Next
From: Michael Paquier
Date:
Subject: Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.