Re: pgsql: Default to hidden visibility for extension libraries where possi - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pgsql: Default to hidden visibility for extension libraries where possi
Date
Msg-id 20220719153149.lhbir3wh4sgfkfe7@awork3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Default to hidden visibility for extension libraries where possi  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Default to hidden visibility for extension libraries where possi
List pgsql-hackers
Hi,

On 2022-07-19 16:28:07 +0200, Alvaro Herrera wrote:
> Anyway, the minimal patch that makes plpgsql_check tests pass is
> attached.  This seems a bit random.  Maybe it'd be better to have a
> plpgsql_internal.h with functions that are exported only for plpgsql
> itself, and keep plpgsql.h with a set of functions, all marked
> PGDLLEXPORT, that are for external use.

It does seem a bit random. But I think we probably should err on the side of
adding more declarations, rather than the oposite.

I like the plpgsql_internal.h idea, but probably done separately?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Costing elided SubqueryScans more nearly correctly
Next
From: Andres Freund
Date:
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size