Re: [Commitfest 2022-07] Begins Now - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [Commitfest 2022-07] Begins Now
Date
Msg-id 20220718193201.3c3qja7dhevgkzuh@awork3.anarazel.de
Whole thread Raw
In response to Re: [Commitfest 2022-07] Begins Now  (Jacob Champion <jchampion@timescale.com>)
Responses Re: [Commitfest 2022-07] Begins Now
List pgsql-hackers
Hi,

On 2022-07-18 12:22:25 -0700, Jacob Champion wrote:
> [dev hat]
> 
> On 7/15/22 18:07, Andres Freund wrote:
> > IDK, I've plenty times given feedback and it took months till it all was
> > implemented. What's the point of doing further rounds of review until then?
> 
> I guess I would wonder why we're optimizing for that case. Is it helpful
> for that patch to stick around in an active CF for months?

I'm not following - I'm talking about the patch author needing a while to
address the higher level feedback given by a reviewer. The author might put
out a couple new versions, which each might still benefit from review. In that
- pretty common imo - situation I don't think it's useful for the reviewer
that provided the higher level feedback to be removed from the patch.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()
Next
From: Robert Haas
Date:
Subject: Re: Use fadvise in wal replay