Re: pgsql: Fix for make unportability - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Fix for make unportability
Date
Msg-id 20220713074504.wknclwsjlvbz4edl@alvherre.pgsql
Whole thread Raw
In response to pgsql: Fix for make unportability  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: Fix for make unportability
List pgsql-committers
On 2022-Jul-13, Peter Eisentraut wrote:

> Fix for make unportability
> 
> 88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell)
> construct that apparently confuses older GNU make versions (possibly
> because of the # inside the shell command?).  This construct, which
> would allow # comments inside LINGUAS files, was adapted from gettext
> recommendations, but we don't actually need that functionality, so
> sidestep this whole issue by just using plain "cat".

I suppose if we're getting rid of Make soon, it's not really very useful
to make this more make-ish:

  AVAIL_LANGUAGES := $(file <$(srcdir)/po/LINGUAS)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/



pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Fix for make unportability
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix XID list support some more