Re: automatically generating node support functions - Mailing list pgsql-hackers

From Andres Freund
Subject Re: automatically generating node support functions
Date
Msg-id 20220711161404.qxq5lwbuzeg63xce@awork3.anarazel.de
Whole thread Raw
In response to Re: automatically generating node support functions  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2022-07-11 12:07:09 -0400, Tom Lane wrote:
> I wrote:
> > Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> >> could not handle type "ScanDirection" in struct "IndexScan" field
> >> "indexorderdir"
>
> > Ah, I see.  Still, we could also handle that with
> > push @enum_types, qw(ScanDirection);
>
> I tried that, and it does work.  The only other input file we could
> get rid of that way is nodes/lockoptions.h, which likewise contributes
> only a couple of enum type names.

Kinda wonder if those headers are even worth having. Plenty other enums in
primnodes.h.


> Not sure it's worth messing with --- both ways seem crufty, though for
> different reasons.

Not sure either.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Gaddam Sai Ram
Date:
Subject: Re: make install-world fails sometimes in Mac M1
Next
From: Robert Haas
Date:
Subject: Re: making relfilenodes 56 bits