Re: should check interrupts in BuildRelationExtStatistics ? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: should check interrupts in BuildRelationExtStatistics ?
Date
Msg-id 20220705232013.56grkfgtfna2cgbq@awork3.anarazel.de
Whole thread Raw
In response to Re: should check interrupts in BuildRelationExtStatistics ?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2022-07-01 19:19:11 -0400, Tom Lane wrote:
> That, um, piqued my interest.  After a bit of digging,
> I modestly propose the attached.  I'm not sure if it's
> okay to back-patch this, because maybe someone out there
> is relying on qsort() to be incapable of throwing an error
> --- but it'd solve the problem at hand and a bunch of other
> issues of the same ilk.

I'm worried about this. Interrupting random qsorts all over seems like it
could end up corrupting state. We do things like qsort in building snapshots
etc. Are we confident that we handle interrupts reliably in all those places?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: should check interrupts in BuildRelationExtStatistics ?
Next
From: Tom Lane
Date:
Subject: Re: should check interrupts in BuildRelationExtStatistics ?