Re: Inconvenience of pg_read_binary_file() - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Inconvenience of pg_read_binary_file()
Date
Msg-id 20220630.105952.545831058411592439.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Inconvenience of pg_read_binary_file()  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Inconvenience of pg_read_binary_file()
List pgsql-hackers
At Tue, 07 Jun 2022 17:29:31 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> pg_read_file(text, bool) makes sense to me, but it doesn't seem like
> to be able to share C function with other variations.
> pg_read_binary_file() need to accept some out-of-range value for
> offset or length to signal that offset and length are not specified.

In this version all the polypmorphic variations share the same body
function.  I tempted to add tail-reading feature but it would be
another feature.

> (function comments needs to be edited and docs are needed)

- Simplified the implementation (by complexifying argument handling..).
- REVOKEd EXECUTE from the new functions.
- Edited the signature of the two functions.

> - pg_read_file ( filename text [, offset bigint, length bigint [, missing_ok boolean ]] ) → text
> + pg_read_file ( filename text [, offset bigint, length bigint ] [, missing_ok boolean ] ) → text

And registered this to the next CF.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: Multi-Master Logical Replication
Next
From: Justin Pryzby
Date:
Subject: Re: Add test of pg_prewarm extenion