ParseTzFile doesn't FreeFile on error - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject ParseTzFile doesn't FreeFile on error
Date
Msg-id 20220530.173740.748502979257582392.horikyota.ntt@gmail.com
Whole thread Raw
Responses Re: ParseTzFile doesn't FreeFile on error  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
While working on some patch, I saw the following error message when a
transaction ended successfully after a failed call to
parse_and_validate_value().

The cause is ParseTzFile() returns leaving an open file descriptor
unfreed in some error cases.

This happens only in a special case when the errors are ignored, but
in principle the file descriptor should be released before exiting the
function.

I'm not sure it's worth fixing but the attached fixes that.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Next
From: Yugo NAGATA
Date:
Subject: Re: Prevent writes on large objects in read-only transactions