Re: Unstable tests for recovery conflict handling - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Unstable tests for recovery conflict handling
Date
Msg-id 20220428013134.gahwtxwfuu6gwfwe@alap3.anarazel.de
Whole thread Raw
In response to Re: Unstable tests for recovery conflict handling  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2022-04-27 14:08:45 -0400, Tom Lane wrote:
> I wrote:
> > It's been kind of hidden by other buildfarm noise, but
> > 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4].
> > ...
> > I think this is showing us a real bug, ie we sometimes fail to cancel
> > the conflicting query.
> 
> After digging around in the code, I think this is almost certainly
> some manifestation of the previously-complained-of problem [1] that
> RecoveryConflictInterrupt is not safe to call in a signal handler,
> leading the conflicting backend to sometimes decide that it's not
> the problem.

I think at least some may actually be because of
https://postgr.es/m/20220409045515.35ypjzddp25v72ou%40alap3.anarazel.de
rather than RecoveryConflictInterrupt itself.

I'll go an finish up the comment bits that I still need to clean up in my
bugix and commit that...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Unstable tests for recovery conflict handling
Next
From: Junwang Zhao
Date:
Subject: Re: remove redundant check of item pointer