Re: test/isolation/expected/stats_1.out broken for me - Mailing list pgsql-hackers

From Andres Freund
Subject Re: test/isolation/expected/stats_1.out broken for me
Date
Msg-id 20220407185408.n7dvsgqsb3q6uze7@alap3.anarazel.de
Whole thread Raw
In response to Re: test/isolation/expected/stats_1.out broken for me  (Andres Freund <andres@anarazel.de>)
Responses Re: test/isolation/expected/stats_1.out broken for me  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2022-04-07 11:02:41 -0700, Andres Freund wrote:
> I've now reproduced this, albeit not reliably yet. Looking.

Caused by me misremembering when deduplication happens - somehow recalled that
deduplication didn't happen when payloads. So the statement that was supposed
to guarantee needing more than one page:
  SELECT pg_notify('stats_test_use', repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);

didn't actually guarantee that. It just failed to fail by chance.

When regression tests and isolation test run in sequence against the same
freshly started cluster, the offsets when starting out are just right to not
need another page in the first test.

I'll change it to use distinct payloads..

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas
Next
From: Andres Freund
Date:
Subject: Re: test/isolation/expected/stats_1.out broken for me