Re: Remove error message hints mentioning configure options - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Remove error message hints mentioning configure options
Date
Msg-id 20220407073431.wugvrnnbquusstkt@alap3.anarazel.de
Whole thread Raw
Responses Re: Remove error message hints mentioning configure options  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Jo.

On 2022-04-07 09:19:14 +0200, Peter Eisentraut wrote:
> I think these hints are usually not useful since users will use packaged
> distributions and won't be interested in rebuilding their installation from
> source.  Also, we have only used these kinds of hints for some features and
> in some places, not consistently throughout.  And of course there are build
> systems that don't use configure.  The information "needs to be built with
> XXX" or "was not built with XXX" should be enough for those interested in
> actually changing their build configuration to figure out what to do.

+1

> diff --git a/src/test/regress/expected/compression_1.out b/src/test/regress/expected/compression_1.out
> index 1ce2962d55..c0a47646eb 100644
> --- a/src/test/regress/expected/compression_1.out
> +++ b/src/test/regress/expected/compression_1.out

The xml stuff is at least old, but compression_1 isn't. I think we've tried to
avoid long alternative output files where everything fails due to being
unsupported for a while now? Robert, Dilip? See uses of :skip_test in various
tests.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: shared-memory based stats collector - v70
Next
From: Michael Paquier
Date:
Subject: Re: Add last commit LSN to pg_last_committed_xact()