On Tue, Apr 05, 2022 at 04:41:28PM +0900, Masahiko Sawada wrote:
> On Tue, Apr 5, 2022 at 4:08 PM Noah Misch <noah@leadboat.com> wrote:
> > On Tue, Apr 05, 2022 at 03:05:10PM +0900, Masahiko Sawada wrote:
> > > I've attached an updated patch. The patch includes a regression test
> > > to detect the new violation as we discussed. I've confirmed that
> > > Cirrus CI tests pass. Please confirm on AIX and review the patch.
> >
> > When the context of a "git grep skiplsn" match involves several struct fields
> > in struct order, please change to the new order. In other words, do for all
> > "git grep skiplsn" matches what the v2 patch does in GetSubscription(). The
> > v2 patch does not do this for catalogs.sgml, but it ought to. I didn't check
> > all the other "git grep" matches; please do so.
>
> Oops, I missed many places. I checked all "git grep" matches and fixed them.
> --- a/src/backend/catalog/system_views.sql
> +++ b/src/backend/catalog/system_views.sql
> @@ -1285,8 +1285,8 @@ REVOKE ALL ON pg_replication_origin_status FROM public;
>
> -- All columns of pg_subscription except subconninfo are publicly readable.
> REVOKE ALL ON pg_subscription FROM public;
> -GRANT SELECT (oid, subdbid, subname, subowner, subenabled, subbinary,
> - substream, subtwophasestate, subdisableonerr, subskiplsn, subslotname,
> +GRANT SELECT (oid, subdbid, subname, subskiplsn, subowner, subenabled,
> + subbinary, substream, subtwophasestate, subdisableonerr, subslotname,
> subsynccommit, subpublications)
subskiplsn comes before subname. Other than that, this looks done. I
recommend committing it with that change.
