Re: turn fastgetattr and heap_getattr to inline functions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: turn fastgetattr and heap_getattr to inline functions
Date
Msg-id 202203241326.puromteoovaz@alvherre.pgsql
Whole thread Raw
In response to Re: turn fastgetattr and heap_getattr to inline functions  (Michael Paquier <michael@paquier.xyz>)
Responses Re: turn fastgetattr and heap_getattr to inline functions  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
On 2022-Mar-24, Michael Paquier wrote:

> Hmm.  I think that you'd better add a return at the end of each
> function?  Some compilers are dumb in detecting that all the code 
> paths return (aka recent d0083c1) and could generate warnings, even if
> things are coded to return all the time, like in your patch.

Hmm, OK to do something about that.  I added pg_unreachable(): looking
at LWLockAttemptLock(), it looks that that should be sufficient.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

Attachment

pgsql-hackers by date:

Previous
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: multithreaded zstd backup compression for client and server
Next
From: Bharath Rupireddy
Date:
Subject: Re: Remove an unnecessary errmsg_plural in dependency.c