Postgres Pro
Downloads
Home   >   mailing lists

Re: Replication slot drop message is sent after pgstats shutdown. - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Replication slot drop message is sent after pgstats shutdown.
Date
Msg-id 20220318.181807.1663734656386361087.horikyota.ntt@gmail.com
Whole thread Raw
In response to Replication slot drop message is sent after pgstats shutdown.  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Tree view 
At Fri, 18 Mar 2022 00:28:37 -0700, Noah Misch <noah@leadboat.com> wrote in 
> ===
> diff -U3 /export/home/nm/farm/studio64v12_6/HEAD/pgsql/contrib/test_decoding/expected/slot_creation_error.out
/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/contrib/test_decoding/output_iso/results/slot_creation_error.out
> --- /export/home/nm/farm/studio64v12_6/HEAD/pgsql/contrib/test_decoding/expected/slot_creation_error.out    Tue Feb
1506:58:14 2022
 
> +++
/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/contrib/test_decoding/output_iso/results/slot_creation_error.out
TueFeb 15 11:38:14 2022
 


> I plan to fix this as attached, similar to how commit c04c767 fixed the same
> challenge in detach-partition-concurrently-[34].

It looks correct and I confirmed that it works.


It looks like a similar issue with [1] but this is cleaner and stable.

[1] https://www.postgresql.org/message-id/20220304.113347.2105652521035137491.horikyota.ntt@gmail.com

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: PROPOSAL: Support global and local disabling of indexes
Next
From: Julien Rouhaud
Date:
Subject: Re: pgsql: Add option to use ICU as global locale provider