Re: pgsql: Add 'basebackup_to_shell' contrib module. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date
Msg-id 20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Add 'basebackup_to_shell' contrib module.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: pgsql: Add 'basebackup_to_shell' contrib module.
List pgsql-committers
Hi,

On 2022-03-15 17:33:12 +0000, Robert Haas wrote:
> Add 'basebackup_to_shell' contrib module.
> 
> As a demonstration of the sort of thing that can be done by adding a
> custom backup target, this defines a 'shell' target which executes a
> command defined by the system administrator. The command is executed
> once for each tar archive generate by the backup and once for the
> backup manifest, if any. Each time the command is executed, it
> receives the contents of th file for which it is executed via standard
> input.
> 
> The configured command can use %f to refer to the name of the archive
> (e.g. base.tar, $TABLESPACE_OID.tar, backup_manifest) and %d to refer
> to the target detail (pg_basebackup --target shell:DETAIL). A target
> detail is required if %d appears in the configured command and
> forbidden if it does not.
> 
> Patch by me, reviewed by Abhijit Menon-Sen.

> Modified Files
> --------------
> contrib/Makefile                                  |   1 +
> contrib/basebackup_to_shell/Makefile              |  19 +
> contrib/basebackup_to_shell/basebackup_to_shell.c | 419 ++++++++++++++++++++++
> doc/src/sgml/basebackup-to-shell.sgml             |  69 ++++
> doc/src/sgml/contrib.sgml                         |   1 +
> doc/src/sgml/filelist.sgml                        |   1 +
> 6 files changed, 510 insertions(+)

Seems like this ought to have at least some basic test to make sure it
actually works / keeps working?

Greetings,

Andres Freund



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Track LLVM 15 changes.
Next
From: David Steele
Date:
Subject: Re: pgsql: Fix pg_basebackup with in-place tablespaces.