Re: row filtering for logical replication - Mailing list pgsql-hackers

From Andres Freund
Subject Re: row filtering for logical replication
Date
Msg-id 20220201013535.54tzdnsizi3g3wik@alap3.anarazel.de
Whole thread Raw
In response to Re: row filtering for logical replication  (Greg Nancarrow <gregn4422@gmail.com>)
List pgsql-hackers
On 2022-01-31 14:12:38 +1100, Greg Nancarrow wrote:
> This array was only ever meant to be read-only, and visible only to
> that function.
> IMO removing "static" makes things worse because now that array gets
> initialized each call to the function, which is unnecessary.
> I think it should just be: "static const int map_changetype_pubaction[] = ..."

Yes, static const is good. static alone, not so much.



pgsql-hackers by date:

Previous
From: Yugo NAGATA
Date:
Subject: Research and Interview on scale-out solutions in Japan
Next
From: Nathan Bossart
Date:
Subject: Re: archive modules