Re: Null commitTS bug - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Null commitTS bug
Date
Msg-id 20220117.111724.632185256127324915.horikyota.ntt@gmail.com
Whole thread Raw
In response to Null commitTS bug  ("Kingsborough, Alex" <kingsboa@amazon.com>)
Responses Re: Null commitTS bug
List pgsql-hackers
At Fri, 14 Jan 2022 22:49:59 +0000, "Kingsborough, Alex" <kingsboa@amazon.com> wrote in
> The fix for this is very simple
>
>
>   /* if we wrote out all subxids, we're done. /
>   - if (j + 1 >= nsubxids)
>   + if (j >= nsubxids)
>   break;

It looks like a thinko and the fix is correct. (It's a matter of taste
choosing between it and "j == nsubxids").

I found some confusing lines around but they need not a fix
considering back-patching conflict?

> for (i = 0, headxid = xid;;)
..
> i += j - i + 1;

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add jsonlog log_destination for JSON server logs
Next
From: Amit Kapila
Date:
Subject: Re: Consistently use the function name CreateCheckPoint instead of CreateCheckpoint in code comments