Re: Add Boolean node - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add Boolean node
Date
Msg-id 20211229203211.do254h4lvp3gruqc@alap3.anarazel.de
Whole thread Raw
In response to Re: Add Boolean node  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add Boolean node  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Add Boolean node  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On 2021-12-27 09:53:32 -0500, Tom Lane wrote:
> Didn't really read the patch in any detail, but I did have one idea:
> I think that the different things-that-used-to-be-Value-nodes ought to
> use different field names, say ival, rval, bval, sval not just "val".
> That makes it more likely that you'd catch any code that is doing the
> wrong thing and not going through one of the access macros.

If we go around changing all these places, it might be worth to also change
Integer to be a int64 instead of an int.



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Strange path from pgarch_readyXlog()
Next
From: Tom Lane
Date:
Subject: Re: Add Boolean node