Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Date
Msg-id 20211211225158.utbyfnfgmvnwn557@alap3.anarazel.de
Whole thread Raw
In response to Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Hi,

On 2021-12-11 13:13:56 -0800, Peter Geoghegan wrote:
> On Sat, Dec 11, 2021 at 12:24 PM Andres Freund <andres@anarazel.de> wrote:
> > But the ereport is inside an if (verbose), no?
> 
> Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the
> autovacuum case still reports verbose-ness, in the same way as it
> always has -- in that same LOG entry. We don't want to repeat
> ourselves in the VERBOSE case, which will have already indicated its
> verboseness in the up-front ereport().

I feel one, or both, must be missing something here. My point was that you
said upthread that the patch doesn't change DEBUG2/non-verbose logging for
most messages. But the fact that those messages are only emitted inside and if
(verbose) seems to contradict that?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Building postgresql from sources, statically linked, linux
Next
From: Peter Geoghegan
Date:
Subject: Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output