Re: pgsql: pgcrypto: Remove non-OpenSSL support - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: pgcrypto: Remove non-OpenSSL support
Date
Msg-id 20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de
Whole thread Raw
In response to pgsql: pgcrypto: Remove non-OpenSSL support  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: pgcrypto: Remove non-OpenSSL support  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Hi,

On 2021-11-05 13:09:55 +0000, Peter Eisentraut wrote:
> pgcrypto: Remove non-OpenSSL support
> 
> pgcrypto had internal implementations of some encryption algorithms,
> as an alternative to calling out to OpenSSL.  These were rarely used,
> since most production installations are built with OpenSSL.  Moreover,
> maintaining parallel code paths makes the code more complex and
> difficult to maintain.
> 
> This patch removes these internal implementations.  Now, pgcrypto is
> only built if OpenSSL support is configured.

This appears to have broken msvc pgcrypto being tested with msvc. I think
that's because pgcrypto is still listed in the "base" @contrib_excludes and
thus just isn't getting built anymore, now that the special-case build rule is
gone?

Greetings,

Andres Freund



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Blind attempt to fix MSVC pgcrypto build.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support