Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot() - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot()
Date
Msg-id 202110261154.yyqlftx4svrk@alvherre.pgsql
Whole thread Raw
In response to Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot()  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot()
List pgsql-hackers
On 2021-Oct-26, Aleksander Alekseev wrote:

> > In short: I'm not okay with doing
> > s/MakeTupleTableSlot/MakeSingleTupleTableSlot/g in a patch that doesn't
> > also introduce matching ExecDropSingleTupleTableSlot calls (unless those
> > exist somewhere already; but where?). If we did clean that up, maybe
> > MakeTupleTableSlot could become "static". But I'd still be inclined to
> > keep it physically separate, leaving it to the compiler to decide whether
> > to inline it into the callers.

Another point that could be made is that perhaps
MakeSingleTupleTableSlot should always construct a slot using virtual
tuples rather than passing TTSOps as a parameter?

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"Ellos andaban todos desnudos como su madre los parió, y también las mujeres,
aunque no vi más que una, harto moza, y todos los que yo vi eran todos
mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot()
Next
From: Shruthi Gowda
Date:
Subject: Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)