On 2021-Aug-29, Tom Lane wrote:
> I stand by my opinion that Thomas' patch is a kluge rather than something
> we should accept as a long-term answer. However, in the interests of
> keeping the buildfarm green, maybe we should commit it until we have a
> better solution. It looks like seawasp is only building HEAD, so I think
> we could commit this in HEAD only.
Well, I definitely agree with your opinion, but perhaps we should
consider what to do in case LLVM developers decide not to care and keep
the rename. I'm not sure that polluting the tree with kludges for
cross-LLVM-version compatibility is the best way to handle this kind of
thing. Maybe it'd be better to try and centralize them in a single file
perhaps. For example, pglogical has files for each PG version it
supports so that the main source code only has to use one wording of
each call:
https://github.com/2ndQuadrant/pglogical/blob/REL2_x_STABLE/compat14/pglogical_compat.hhttps://github.com/2ndQuadrant/pglogical/blob/REL2_x_STABLE/compat96/pglogical_compat.c
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La rebeldía es la virtud original del hombre" (Arthur Schopenhauer)
