Re: archive status ".ready" files may be created too early - Mailing list pgsql-hackers

From Andres Freund
Subject Re: archive status ".ready" files may be created too early
Date
Msg-id 20210829023722.cz6nbehyupp3hemk@alap3.anarazel.de
Whole thread Raw
In response to Re: archive status ".ready" files may be created too early  ("alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>)
Responses Re: archive status ".ready" files may be created too early  ("alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi,

On 2021-08-23 15:55:03 -0400, alvherre@alvh.no-ip.org wrote:
> On 2021-Aug-23, Bossart, Nathan wrote:
> 
> > Ah, okay.  BTW the other changes you mentioned made sense to me.
> 
> Thanks.  I've pushed this now to all live branches.

While rebasing the aio patchset ontop of HEAD I noticed that this commit added
another atomic operation to XLogWrite() with archiving enabled. The WAL write
path is really quite hot, and at least some of the
NotifySegmentsReadyForArchive() calls are done while WALWriteLock is held.

I think we should at least try to make the fast-path where no segment
boundaries were crossed use no atomic operations.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.
Next
From: Himanshu Upadhyaya
Date:
Subject: inconsistent behavior with "GENERATED BY DEFAULT AS IDENTITY"