Re: EXEC_BACKEND vs bgworkers without BGWORKER_SHMEM_ACCESS - Mailing list pgsql-hackers

From Andres Freund
Subject Re: EXEC_BACKEND vs bgworkers without BGWORKER_SHMEM_ACCESS
Date
Msg-id 20210806025649.aa3scndaibiyhq6u@alap3.anarazel.de
Whole thread Raw
In response to Re: EXEC_BACKEND vs bgworkers without BGWORKER_SHMEM_ACCESS  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: EXEC_BACKEND vs bgworkers without BGWORKER_SHMEM_ACCESS  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2021-08-05 20:02:02 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > First, what do we want to do with BGWORKER_SHMEM_ACCESS? I'm inclined to treat
> > it as a required flag going forward.
> 
> +1
> 
> > The second question is what we want to do in the backbranches. I think the
> > reasonable options are to do nothing, or to make !BGWORKER_SHMEM_ACCESS an
> > error in SanityCheckBackgroundWorker() if EXEC_BACKEND is used.
> 
> I think doing nothing is fine.  Given the lack of complaints, we're
> more likely to break something than fix anything useful.

Done in the attached patch. I don't think we need to add more to the docs than
the flag being required?

Greetings,

Andres Freund

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: .ready and .done files considered harmful
Next
From: Tom Lane
Date:
Subject: Re: Numeric x^y for negative x