Re: Improving isolationtester's data output - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Improving isolationtester's data output
Date
Msg-id 202106152320.xfiprkh4sp5c@alvherre.pgsql
Whole thread Raw
In response to Improving isolationtester's data output  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Improving isolationtester's data output
Re: Improving isolationtester's data output
List pgsql-hackers
On 2021-Jun-15, Tom Lane wrote:

> I've been spending a lot of time looking at isolationtester results
> over the past couple of days, and gotten really annoyed at how poorly
> it formats query results.  In particular, any column heading or value
> that is 15 characters or longer is not separated from the next column,
> rendering the output quite confusing.

Yeah, I noticed this too.

> Attached is a little hack that tries to improve that case while making
> minimal changes to the output files otherwise.

Seems pretty reasonable.

> There's still a good deal to be desired here: notably, the code still
> does nothing to ensure vertical alignment of successive lines when
> there are wide headings or values.  But doing anything about that
> would involve much-more-invasive changes of the output files.
> If we wanted to buy into that, I'd think about discarding this
> ad-hoc code altogether in favor of using one of libpq's fe-print.c
> routines.  But I'm not really sure that the small legibility gains
> that would result are worth massive changes in the output files.

Shrug -- it's a one time change.  It wouldn't bother me, for one.

-- 
Álvaro Herrera       Valdivia, Chile
"Hay que recordar que la existencia en el cosmos, y particularmente la
elaboración de civilizaciones dentro de él no son, por desgracia,
nada idílicas" (Ijon Tichy)



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Next
From: Tom Lane
Date:
Subject: Re: Improving isolationtester's data output