Re: Adjust pg_regress output for new long test names - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Adjust pg_regress output for new long test names
Date
Msg-id 20210609025129.GC475088@rfd.leadboat.com
Whole thread Raw
In response to Adjust pg_regress output for new long test names  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Adjust pg_regress output for new long test names
Re: Adjust pg_regress output for new long test names
List pgsql-hackers
On Wed, Jun 09, 2021 at 01:57:45PM +1200, Thomas Munro wrote:
> test deadlock-simple              ... ok           20 ms
> test deadlock-hard                ... ok        10624 ms
> test deadlock-soft                ... ok          147 ms
> test deadlock-soft-2              ... ok         5154 ms
> test deadlock-parallel            ... ok          132 ms
> test detach-partition-concurrently-1 ... ok          553 ms
> test detach-partition-concurrently-2 ... ok          234 ms
> test detach-partition-concurrently-3 ... ok         2389 ms
> test detach-partition-concurrently-4 ... ok         1876 ms

> Make the test output visually consistent, as previously done by commit
> 14378245.

Not bad, but I would instead shorten the names to detach-[1234] or
detach-partition-[1234].  The marginal value of the second word is low, and
the third word helps even less.

> -            status(_("test %-28s ... "), tests[0]);
> +            status(_("test %-32s ... "), tests[0]);

As the whitespace gulf widens, it gets harder to match left and right sides
visually.  We'd cope of course, but wider spacing isn't quite free.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Unused function parameter in get_qual_from_partbound()
Next
From: Amit Kapila
Date:
Subject: Re: locking [user] catalog tables vs 2pc vs logical rep