Postgres Pro
Downloads
Home   >   mailing lists

Re: Fixup some appendStringInfo and appendPQExpBuffer calls - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date
Msg-id 202106021057.olomemdqjocu@alvherre.pgsql
Whole thread Raw
In response to Fixup some appendStringInfo and appendPQExpBuffer calls  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses Re: Fixup some appendStringInfo and appendPQExpBuffer calls  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 2021-Jun-02, houzj.fnst@fujitsu.com wrote:

> Hi,
> 
> In the latest HEAD branch, I found some places were using
> appendStringInfo/appendPQExpBuffer() when they could have been using
> appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better
> fix these places in case other developers will use these codes as a reference,
> though, it seems will not bring noticeable performance gain.

hmm why didn't we get warnings about the PENDING DETACH one?  Maybe we
need some decorator in PQExpBuffer.


-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"La espina, desde que nace, ya pincha" (Proverbio africano)

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Alias collision in `refresh materialized view concurrently`
Next
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: tab-complete for CREATE TYPE ... SUBSCRIPT